linux-kernel - [PATCH 4.9 27/50] fs: fix lost error code in dio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181204103715.881910575@linuxfoundation.org>
Date:   Tue,  4 Dec 2018 11:50:22 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org, Ravi Nankani <rnankani@...zon.com>,
        Maximilian Heyne <mheyne@...zon.de>,
        Christoph Hellwig <hch@....de>,
        Torsten Mehlan <tomeh@...zon.de>,
        Uwe Dannowski <uwed@...zon.de>, Amit Shah <aams@...zon.de>,
        David Woodhouse <dwmw@...zon.co.uk>,
        Jens Axboe <axboe@...nel.dk>
Subject: [PATCH 4.9 27/50] fs: fix lost error code in dio_complete

4.9-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Maximilian Heyne <mheyne@...zon.de>

commit 41e817bca3acd3980efe5dd7d28af0e6f4ab9247 upstream.

commit e259221763a40403d5bb232209998e8c45804ab8 ("fs: simplify the
generic_write_sync prototype") reworked callers of generic_write_sync(),
and ended up dropping the error return for the directio path. Prior to
that commit, in dio_complete(), an error would be bubbled up the stack,
but after that commit, errors passed on to dio_complete were eaten up.

This was reported on the list earlier, and a fix was proposed in
https://lore.kernel.org/lkml/20160921141539.GA17898@infradead.org/, but
never followed up with.  We recently hit this bug in our testing where
fencing io errors, which were previously erroring out with EIO, were
being returned as success operations after this commit.

The fix proposed on the list earlier was a little short -- it would have
still called generic_write_sync() in case `ret` already contained an
error. This fix ensures generic_write_sync() is only called when there's
no pending error in the write. Additionally, transferred is replaced
with ret to bring this code in line with other callers.

Fixes: e259221763a4 ("fs: simplify the generic_write_sync prototype")
Reported-by: Ravi Nankani <rnankani@...zon.com>
Signed-off-by: Maximilian Heyne <mheyne@...zon.de>
Reviewed-by: Christoph Hellwig <hch@....de>
CC: Torsten Mehlan <tomeh@...zon.de>
CC: Uwe Dannowski <uwed@...zon.de>
CC: Amit Shah <aams@...zon.de>
CC: David Woodhouse <dwmw@...zon.co.uk>
CC: stable@...r.kernel.org
Signed-off-by: Jens Axboe <axboe@...nel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

---
 fs/direct-io.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/fs/direct-io.c
+++ b/fs/direct-io.c
@@ -278,8 +278,8 @@ static ssize_t dio_complete(struct dio *
 		 */
 		dio->iocb->ki_pos += transferred;

-		if (dio->op == REQ_OP_WRITE)
-			ret = generic_write_sync(dio->iocb,  transferred);
+		if (ret > 0 && dio->op == REQ_OP_WRITE)
+			ret = generic_write_sync(dio->iocb, ret);
 		dio->iocb->ki_complete(dio->iocb, ret, 0);
 	}