linux-kernel - Re: [PATCH v2 2/2] drm/ast: Fix connector leak during driver unload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181204121323.GC21184@phenom.ffwll.local>
Date:   Tue, 4 Dec 2018 13:13:23 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Sam Bobroff <sbobroff@...ux.ibm.com>
Cc:     daniel@...ll.ch, airlied@...hat.com, airlied@...ux.ie,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] drm/ast: Fix connector leak during driver unload

On Mon, Dec 03, 2018 at 11:53:21AM +1100, Sam Bobroff wrote:
> When unloading the ast driver, a warning message is printed by
> drm_mode_config_cleanup() because a reference is still held to one of
> the drm_connector structs.
> 
> Correct this by calling drm_crtc_force_disable_all() in
> ast_fbdev_destroy().
> 
> Signed-off-by: Sam Bobroff <sbobroff@...ux.ibm.com>
> ---
> v2 * Changed to use drm_crtc_force_disable_all().

Reviewed-by: Daniel Vetter <daniel.vetter@...ll.ch>

> 
>  drivers/gpu/drm/ast/ast_fb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
> index 0cd827e11fa2..de26df0c6044 100644
> --- a/drivers/gpu/drm/ast/ast_fb.c
> +++ b/drivers/gpu/drm/ast/ast_fb.c
> @@ -263,6 +263,7 @@ static void ast_fbdev_destroy(struct drm_device *dev,
>  {
>  	struct ast_framebuffer *afb = &afbdev->afb;
>  
> +	drm_crtc_force_disable_all(dev);
>  	drm_fb_helper_unregister_fbi(&afbdev->helper);
>  
>  	if (afb->obj) {
> -- 
> 2.19.0.2.gcad72f5712
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch