linux-kernel - Re: Linux-next: Build failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+G9fYt020CHvoH32KgdjKordVtG+VmriKEFqa1HTzWJTYf-nQ@mail.gmail.com>
Date:   Tue, 4 Dec 2018 20:16:33 +0530
From:   Naresh Kamboju <naresh.kamboju@...aro.org>
To:     Will Deacon <will.deacon@....com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        linux-arm-kernel@...ts.infradead.org,
        Peter Zijlstra <peterz@...radead.org>,
        Mark Rutland <mark.rutland@....com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: Linux-next: Build failed

Hi Will,

On Tue, 4 Dec 2018 at 18:22, Will Deacon <will.deacon@....com> wrote:
>
> Hi Naresh,
>
> On Tue, Dec 04, 2018 at 05:56:09PM +0530, Naresh Kamboju wrote:
> > FYI,
> >
> > The Linux -next build failed due to below warnings/errors.
> >
> > include/asm-generic/bitops/atomic.h: In function 'set_bit':
> > include/asm-generic/bitops/atomic.h:17:2: error: implicit declaration
> > of function 'atomic_long_or'; did you mean '__atomic_load_n'?
> > [-Werror=implicit-function-declaration]
> >   atomic_long_or(BIT_MASK(nr), (atomic_long_t *)p);
> >   ^~~~~~~~~~~~~~
> >   __atomic_load_n
>
> Ha, I like that the compiler is trying to get us to use its __atomic
> builtins here :)
>
> Anyway, you're seeing this because of this previous error in Mark's script:
>
> .../scripts/atomic/atomic-tbl.sh: line 183: fold: command not found
>
> even though fold is part of coreutils :/
>
> Do you have grep? Maybe the diff below helps.

Yes. grep is present.
Thanks for the quick patch.

- Naresh

>
> Will
>
> --->8
>
> diff --git a/scripts/atomic/atomic-tbl.sh b/scripts/atomic/atomic-tbl.sh
> index 9d6be538a987..81d5c32039dd 100755
> --- a/scripts/atomic/atomic-tbl.sh
> +++ b/scripts/atomic/atomic-tbl.sh
> @@ -180,7 +180,7 @@ gen_proto_variants()
>  #gen_proto(meta, ...)
>  gen_proto() {
>         local meta="$1"; shift
> -       for m in $(echo "${meta}" | fold -w1); do
> +       for m in $(echo "${meta}" | grep -o .); do
>                 gen_proto_variants "${m}" "$@"
>         done
>  }
>