linux-kernel - Re: [PATCH 00/13 v2] Regulator ena

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbJEYBQYF2T+UT-t0OYGs1Dj5M7AMEXJWdE282njXfcFw@mail.gmail.com>
Date:   Wed, 5 Dec 2018 15:32:19 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Marek Szyprowski <m.szyprowski@...sung.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH 00/13 v2] Regulator ena_gpiod fixups

On Wed, Dec 5, 2018 at 3:30 PM Marek Szyprowski
<m.szyprowski@...sung.com> wrote:

> > I just sent a fix for that, subject:
> > "gpio: devres: Handle nonexclusive GPIOs"
> > you could perhaps try it on top of this
> > series? I intend to merge that separately as a fix for current,
> > as it is a bug.
>
> Those 2 warnings were worrying me and I finally found! devres_*
> functions require to pass a pointer to the pointer as match_data, so
> desc must be passed as &desc to devres_find() and devres_destroy()
> functions, otherwise they always return -ENOENT. I will comment
> respective lines in your patches then.

Ah thanks so much Marek!

I will follow up with a v4 patch set immediately once I have it nailed
down. Devres is tricky, and I'm not the smartest...

Yours,
Linus Walleij