linux-kernel - Re: [PATCH v3 4/4] scsi: hisi_sas: Add support for DIF feature for v3 hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c08d3fa-5043-7d38-7b6c-574b7344409b@huawei.com>
Date:   Wed, 5 Dec 2018 15:12:27 +0000
From:   John Garry <john.garry@...wei.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     <jejb@...ux.vnet.ibm.com>, <linuxarm@...wei.com>,
        <linux-kernel@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
        Xiang Chen <chenxiang66@...ilicon.com>
Subject: Re: [PATCH v3 4/4] scsi: hisi_sas: Add support for DIF feature for v3
 hw

On 05/12/2018 02:14, Martin K. Petersen wrote:
>
> John,

Hi Martin,

>
>> Are you happy for us to make DIX support in this driver "hisi_sas DIX
>> experimental" short term?
>
> That's entirely your call, it's your driver/controller.  I just want the
> experimental tag to be due to reasons on *your* end.
>

Well unfortunately at the moment we cannot definitively say that it is 
an issue on our end. There's a reasonable chance it is.

> If it's reasons on my end they'll need to get fixed. We shouldn't have
> drivers circumventing features because of bugs in the core block/SCSI
> code...
>

Right, of course not. I'm just a bit stuck now, since we need to 
upstream the DIF support ASAP, but it is being held back by the DIX support.

You did request not to throw away DIX support, so I can send a new 
patchset with DIF and DIX support separated out, and we can leave the 
DIX patch in limbo until we get to the bottom of the DIX issue.

I hope it's ok.

Thanks,
John