linux-kernel - Re: [PATCH 6/5] x86/fault: Clean up the page fault oops decoder a bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <C853E326-E758-4B9B-98DF-73C00D5244B6@amacapital.net>
Date:   Wed, 5 Dec 2018 07:54:11 -0800
From:   Andy Lutomirski <luto@...capital.net>
To:     Sean Christopherson <sean.j.christopherson@...el.com>
Cc:     Andy Lutomirski <luto@...nel.org>, Ingo Molnar <mingo@...nel.org>,
        X86 ML <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
        Yu-cheng Yu <yu-cheng.yu@...el.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH 6/5] x86/fault: Clean up the page fault oops decoder a bit




> +       err_str_append(error_code, err_txt, X86_PF_INSTR, "[INSTR]", NULL);
> +       err_str_append(error_code, err_txt, X86_PF_PK,    "[PK]"   , NULL);
> +       err_str_append(error_code, err_txt, X86_PF_WRITE | X86_PF_INSTR, NULL,
> +                                                         "[READ]");

Ah, I see the issue.  OTOH, printing [READ] [INSTR] wouldn’t be so bad, either.