linux-kernel - Re: [PATCH -next] coresight: stm: remove set but not used variable 'res

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 5 Dec 2018 10:24:16 -0700
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     yuehaibing@...wei.com
Cc:     "Suzuki K. Poulose" <suzuki.poulose@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre TORGUE <alexandre.torgue@...com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-stm32@...md-mailman.stormreply.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] coresight: stm: remove set but not used variable 'res_size'

On Sat, 1 Dec 2018 at 01:31, YueHaibing <yuehaibing@...wei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/hwtracing/coresight/coresight-stm.c: In function 'stm_probe':
> drivers/hwtracing/coresight/coresight-stm.c:796:9: warning:
>  variable 'res_size' set but not used [-Wunused-but-set-variable]
>
> It never used since introduction in commit
> 237483aa5cf4 ("coresight: stm: adding driver for CoreSight STM component")
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied - thanks,
Mathieu

> ---
>  drivers/hwtracing/coresight/coresight-stm.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-stm.c b/drivers/hwtracing/coresight/coresight-stm.c
> index ef339ff..f07825d 100644
> --- a/drivers/hwtracing/coresight/coresight-stm.c
> +++ b/drivers/hwtracing/coresight/coresight-stm.c
> @@ -793,7 +793,7 @@ static int stm_probe(struct amba_device *adev, const struct amba_id *id)
>         struct stm_drvdata *drvdata;
>         struct resource *res = &adev->res;
>         struct resource ch_res;
> -       size_t res_size, bitmap_size;
> +       size_t bitmap_size;
>         struct coresight_desc desc = { 0 };
>         struct device_node *np = adev->dev.of_node;
>
> @@ -833,15 +833,11 @@ static int stm_probe(struct amba_device *adev, const struct amba_id *id)
>
>         drvdata->write_bytes = stm_fundamental_data_size(drvdata);
>
> -       if (boot_nr_channel) {
> +       if (boot_nr_channel)
>                 drvdata->numsp = boot_nr_channel;
> -               res_size = min((resource_size_t)(boot_nr_channel *
> -                                 BYTES_PER_CHANNEL), resource_size(res));
> -       } else {
> +       else
>                 drvdata->numsp = stm_num_stimulus_port(drvdata);
> -               res_size = min((resource_size_t)(drvdata->numsp *
> -                                BYTES_PER_CHANNEL), resource_size(res));
> -       }
> +
>         bitmap_size = BITS_TO_LONGS(drvdata->numsp) * sizeof(long);
>
>         guaranteed = devm_kzalloc(dev, bitmap_size, GFP_KERNEL);
>
>
>