linux-kernel - Re: [PATCH] firmware: qcom: scm: fix compilation error when disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181205173721.GA5232@tuxbook-pro>
Date:   Wed, 5 Dec 2018 09:37:21 -0800
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Jonathan Marek <jonathan@...ek.ca>
Cc:     Andy Gross <andy.gross@...aro.org>,
        Niklas Cassel <niklas.cassel@...aro.org>,
        Kalle Valo <kvalo@...eaurora.org>,
        Brian Norris <briannorris@...omium.org>,
        Jordan Crouse <jcrouse@...eaurora.org>,
        Govind Singh <govinds@...eaurora.org>,
        open list <linux-kernel@...r.kernel.org>,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH] firmware: qcom: scm: fix compilation error when disabled

+ linux-arm-msm

On Wed 21 Nov 18:32 PST 2018, Jonathan Marek wrote:

> This fixes the case when CONFIG_QCOM_SCM is not enabled, and linux/errno.h
> has not been included previously.
> 
> Signed-off-by: Jonathan Marek <jonathan@...ek.ca>

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Regards,
Bjorn

> ---
> drm/msm includes qcom_scm.h, but can be used with non-qcom hw (IMX5)
> 
>  include/linux/qcom_scm.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/qcom_scm.h b/include/linux/qcom_scm.h
> index 06996ad4f2bc..1637385bcc17 100644
> --- a/include/linux/qcom_scm.h
> +++ b/include/linux/qcom_scm.h
> @@ -67,6 +67,9 @@ extern int qcom_scm_iommu_secure_ptbl_init(u64 addr, u32 size, u32 spare);
>  extern int qcom_scm_io_readl(phys_addr_t addr, unsigned int *val);
>  extern int qcom_scm_io_writel(phys_addr_t addr, unsigned int val);
>  #else
> +
> +#include <linux/errno.h>
> +
>  static inline
>  int qcom_scm_set_cold_boot_addr(void *entry, const cpumask_t *cpus)
>  {
> -- 
> 2.17.1
>