linux-kernel - Re: [PATCH v2] drivers/scsi/fnic/fnic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJr6mf1wqNq02e89U85u=h1Ge0MSzAOk+wQc9q_gWurEZzWZUw@mail.gmail.com>
Date:   Wed, 5 Dec 2018 10:07:51 +0530
From:   Sabyasachi Gupta <sabyasachi.linux@...il.com>
To:     satishkh@...co.com, sebaddel@...co.com, kartilak@...co.com,
        jejb@...ux.vnet.ibm.com, martin.petersen@...cle.com
Cc:     Souptick Joarder <jrdr.linux@...il.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Brajeswar Ghosh <brajeswar.linux@...il.com>
Subject: Re: [PATCH v2] drivers/scsi/fnic/fnic_trace.c: Use vzalloc

On Fri, Nov 23, 2018 at 8:13 PM Sabyasachi Gupta
<sabyasachi.linux@...il.com> wrote:
>
> On Wed, Nov 14, 2018 at 10:24 PM Sabyasachi Gupta
> <sabyasachi.linux@...il.com> wrote:
> >
> > Replaced vmalloc + memset with vzalloc
> >
> > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@...il.com>
>
> Any comment on this patch?

Any comment on this patch?

>
> > ---
> > v2: Removed additional braces
> >
> >  drivers/scsi/fnic/fnic_trace.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/scsi/fnic/fnic_trace.c b/drivers/scsi/fnic/fnic_trace.c
> > index 8271785..bf0fd2a 100644
> > --- a/drivers/scsi/fnic/fnic_trace.c
> > +++ b/drivers/scsi/fnic/fnic_trace.c
> > @@ -468,14 +468,13 @@ int fnic_trace_buf_init(void)
> >         fnic_max_trace_entries = (trace_max_pages * PAGE_SIZE)/
> >                                           FNIC_ENTRY_SIZE_BYTES;
> >
> > -       fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * PAGE_SIZE));
> > +       fnic_trace_buf_p = (unsigned long)vzalloc(trace_max_pages * PAGE_SIZE);
> >         if (!fnic_trace_buf_p) {
> >                 printk(KERN_ERR PFX "Failed to allocate memory "
> >                                   "for fnic_trace_buf_p\n");
> >                 err = -ENOMEM;
> >                 goto err_fnic_trace_buf_init;
> >         }
> > -       memset((void *)fnic_trace_buf_p, 0, (trace_max_pages * PAGE_SIZE));
> >
> >         fnic_trace_entries.page_offset =
> >                 vmalloc(array_size(fnic_max_trace_entries,
> > --
> > 2.7.4
> >