linux-kernel - Re: [PATCH] ethernet: fman: fix wrong of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181204.204302.423566091009488276.davem@davemloft.net>
Date:   Tue, 04 Dec 2018 20:43:02 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     nsaenzjulienne@...e.de
Cc:     madalin.bucur@....com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ethernet: fman: fix wrong of_node_put() in probe
 function

From: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
Date: Mon,  3 Dec 2018 13:21:01 +0100

> After getting a reference to the platform device's of_node the probe
> function ends up calling of_find_matching_node() using the node as an
> argument. The function takes care of decreasing the refcount on it. We
> are then incorrectly decreasing the refcount on that node again.
> 
> This patch removes the unwarranted call to of_node_put().
> 
> Fixes: 414fd46e7762 ("fsl/fman: Add FMan support")
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>

Applied, thank you.