linux-kernel - Re: [PATCH 1/2] staging: greybus: Align function call parameters to parenthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181205210951.GA24993@peano>
Date:   Wed, 5 Dec 2018 22:09:51 +0100
From:   Sicilia Cristian <sicilia.cristian@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Bryan O Donoghue <pure.logic@...us-software.ie>,
        Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        greybus-dev@...ts.linaro.org
Subject: Re: [PATCH 1/2] staging: greybus: Align function call parameters to
 parenthesis

On Wed, Dec 05, 2018 at 09:46:03AM +0100, Greg Kroah-Hartman wrote:
> On Tue, Dec 04, 2018 at 09:58:14PM +0100, Cristian Sicilia wrote:
> > Aligned some parameters to the previous parenthesis.
> > 
> > Signed-off-by: Cristian Sicilia <sicilia.cristian@...il.com>
> > ---
> >  drivers/staging/greybus/loopback.c | 10 ++++++----
> >  1 file changed, 6 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
> > index e4d42c1..1085e06 100644
> > --- a/drivers/staging/greybus/loopback.c
> > +++ b/drivers/staging/greybus/loopback.c
> > @@ -638,7 +638,8 @@ static int gb_loopback_async_transfer(struct gb_loopback *gb, u32 len)
> >  	retval = gb_loopback_async_operation(gb, GB_LOOPBACK_TYPE_TRANSFER,
> >  					     request, len + sizeof(*request),
> >  					     len + response_len,
> > -					     gb_loopback_async_transfer_complete);
> > +					     gb_loopback_async_transfer_complete
> > +					     );
> 
> Ick, why do this?  That's not really needed.
> 

Ok, better to leave it unchanged

> thanks,
> 
> greg k-h

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)