linux-kernel - Re: [PATCH] pinctrl: nuvoton: check for devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZPs0C-14itiR9xM+WPegNHBo9MgyHL5fPBxdZ8V3fUaw@mail.gmail.com>
Date:   Wed, 5 Dec 2018 22:55:39 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Nicholas Mc Guire <hofrat@...dl.org>
Cc:     Tomer Maimon <tmaimon77@...il.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: nuvoton: check for devm_kasprintf() failure

On Fri, Nov 23, 2018 at 5:18 PM Nicholas Mc Guire <hofrat@...dl.org> wrote:

> devm_kasprintf() may return NULL on failure of internal allocation thus
> the assignment to  .label  is not safe if not checked. On error
> npcm7xx_gpio_of() returns negative values so -ENOMEM in the
> (unlikely) failure case of devm_kasprintf() should be fine here.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
> Fixes: 3b588e43ee5c ("pinctrl: nuvoton: add NPCM7xx pinctrl and GPIO driver")

Patch applied.

Yours,
Linus Walleij