linux-kernel - Re: [PATCH] selftests: gpio: Find libmount with pkg-config if available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADYN=9LEVUgz_ou6kWrXZGBpUZ5Ti7BB+0Uxp1NtP18BJDVHCg@mail.gmail.com>
Date:   Thu, 6 Dec 2018 00:15:13 +0100
From:   Anders Roxell <anders.roxell@...aro.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Daniel Díaz <daniel.diaz@...aro.org>,
        Shuah Khan <shuah@...nel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        Bamvor Zhang <bamv2005@...il.com>, brgl@...ev.pl,
        linux-gpio@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] selftests: gpio: Find libmount with pkg-config if available

On Wed, 5 Dec 2018 at 22:50, Linus Walleij <linus.walleij@...aro.org> wrote:
>
> Sorry for top-posting,
>
> I don't understand the selftest environment very well so I do not know
> if this is the right thing to do.
>
> I can merge the patch through the GPIO tree but I need a nod from
> someone wise, like Shuah Khan or Anders Roxell (Anders has been
> using the GPIO selftests) that this is the direction we want to go.

Yes this makes sense and its already in linux-next.

Cheers,
Anders

>
> Yours,
> Linus Walleij
>
> On Tue, Oct 16, 2018 at 11:47 PM Daniel Díaz <daniel.diaz@...aro.org> wrote:
>
> > If pkg-config is available, use it to define the CFLAGS and
> > LDLIBS needed for libmount; else, use the current hard-coded
> > paths and options.
> >
> > Using pkg-config is very helpful for cross-compilation
> > environments, and is sometimes readily available on developer
> > boxes to ensure we get the right compiler/linker options for
> > the given package.
> >
> > Signed-off-by: Daniel Díaz <daniel.diaz@...aro.org>
> > ---
> >  tools/testing/selftests/gpio/Makefile | 10 ++++++++--
> >  1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/testing/selftests/gpio/Makefile b/tools/testing/selftests/gpio/Makefile
> > index 46648427d537..f22b22aef7bf 100644
> > --- a/tools/testing/selftests/gpio/Makefile
> > +++ b/tools/testing/selftests/gpio/Makefile
> > @@ -1,7 +1,13 @@
> >  # SPDX-License-Identifier: GPL-2.0
> >
> > -CFLAGS += -O2 -g -std=gnu99 -Wall -I../../../../usr/include/
> > -LDLIBS += -lmount -I/usr/include/libmount
> > +MOUNT_CFLAGS := $(shell pkg-config --cflags mount 2>/dev/null)
> > +MOUNT_LDLIBS := $(shell pkg-config --libs mount 2>/dev/null)
> > +ifeq ($(MOUNT_LDLIBS),)
> > +MOUNT_LDLIBS := -lmount -I/usr/include/libmount
> > +endif
> > +
> > +CFLAGS += -O2 -g -std=gnu99 -Wall -I../../../../usr/include/ $(MOUNT_CFLAGS)
> > +LDLIBS += $(MOUNT_LDLIBS)
> >
> >  TEST_PROGS := gpio-mockup.sh
> >  TEST_FILES := gpio-mockup-sysfs.sh
> > --
> > 2.17.1
> >