linux-kernel - Re: [PATCH] drivers/scsi/snic/snic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <B16AE34C-4395-434E-98AD-C5F7AB818C49@cisco.com>
Date:   Wed, 5 Dec 2018 06:28:02 +0000
From:   "Sesidhar Baddela (sebaddel)" <sebaddel@...co.com>
To:     Sabyasachi Gupta <sabyasachi.linux@...il.com>,
        "Karan Tilak Kumar (kartilak)" <kartilak@...co.com>,
        "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     Souptick Joarder <jrdr.linux@...il.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Brajeswar Ghosh <brajeswar.linux@...il.com>
Subject: Re: [PATCH] drivers/scsi/snic/snic_trc.c: Use vzalloc

Looks good to me.

Acked-by:   Sesidhar Baddela     <sebaddel@...co.com>

On 12/4/18, 8:33 PM, "Sabyasachi Gupta" <sabyasachi.linux@...il.com> wrote:

    On Fri, Nov 23, 2018 at 8:07 PM Sabyasachi Gupta
    <sabyasachi.linux@...il.com> wrote:
    >
    > On Thu, Nov 15, 2018 at 10:04 PM Sabyasachi Gupta
    > <sabyasachi.linux@...il.com> wrote:
    > >
    > > Replaced vmalloc + memset with vzalloc
    > >
    > > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@...il.com>
    >
    > Any comment on this patch?
    
    Any comment on this patch?
    
    >
    > > ---
    > >  drivers/scsi/snic/snic_trc.c | 3 +--
    > >  1 file changed, 1 insertion(+), 2 deletions(-)
    > >
    > > diff --git a/drivers/scsi/snic/snic_trc.c b/drivers/scsi/snic/snic_trc.c
    > > index fc60c93..458eaba 100644
    > > --- a/drivers/scsi/snic/snic_trc.c
    > > +++ b/drivers/scsi/snic/snic_trc.c
    > > @@ -126,7 +126,7 @@ snic_trc_init(void)
    > >         int tbuf_sz = 0, ret;
    > >
    > >         tbuf_sz = (snic_trace_max_pages * PAGE_SIZE);
    > > -       tbuf = vmalloc(tbuf_sz);
    > > +       tbuf = vzalloc(tbuf_sz);
    > >         if (!tbuf) {
    > >                 SNIC_ERR("Failed to Allocate Trace Buffer Size. %d\n", tbuf_sz);
    > >                 SNIC_ERR("Trace Facility not enabled.\n");
    > > @@ -135,7 +135,6 @@ snic_trc_init(void)
    > >                 return ret;
    > >         }
    > >
    > > -       memset(tbuf, 0, tbuf_sz);
    > >         trc->buf = (struct snic_trc_data *) tbuf;
    > >         spin_lock_init(&trc->lock);
    > >
    > > --
    > > 2.7.4
    > >