linux-kernel - Re: [PATCH v2] x86/build: fix compiler support check for CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50d52efb-622e-e5fc-558e-d1a08de902e9@linux.ee>
Date:   Wed, 5 Dec 2018 08:59:58 +0200
From:   Meelis Roos <mroos@...ux.ee>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org
Cc:     Zhenzhong Duan <zhenzhong.duan@...cle.com>,
        Meelis Roos <mroos@...ux.ee>, "H. Peter Anvin" <hpa@...or.com>,
        Borislav Petkov <bp@...en8.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] x86/build: fix compiler support check for
 CONFIG_RETPOLINE

05.12.18 08:27 Masahiro Yamada kirjutas:
> The easiest fix is to move this check to the "archprepare" like commit
> 829fe4aa9ac1 ("x86: Allow generating user-space headers without a
> compiler") did.
> 
> Link: https://lkml.org/lkml/2018/12/4/206
> Fixes: 4cd24de3a098 ("x86/retpoline: Make CONFIG_RETPOLINE depend on compiler support")
> Reported-by: Meelis Roos <mroos@...ux.ee>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
> Changes in v2:
>    - Revive ifdef CONFIG_RETPOLINE surrounding the KBUILD_CFLAGS addition
>    - Rephase the commit log a bit, hoping the cause of the issue will be clearer

Works for me - first it did

scripts/kconfig/conf  --syncconfig Kconfig

and then started compiling. The #define is gone from include/linux.

Thank you!

-- 
Meelis Roos <mroos@...ux.ee>