linux-kernel - Re: [PATCH] perf/core: declare the percpu variable properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3fe7070-6529-902f-7e8c-96ef244893c7@codeaurora.org>
Date:   Wed, 5 Dec 2018 13:13:17 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     linux-kernel@...r.kernel.org
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH] perf/core: declare the percpu variable properly

Hi All,

Can you please review the change ?

Thanks,
Mukesh


On 11/27/2018 2:43 PM, Mukesh Ojha wrote:
> Sparse reports the current declaration of percpu variable with
> below warning
>
> warning: incorrect type in initializer (different address spaces)
>           expected void const [noderef] <asn:3>*__vpp_verify
>           got struct perf_cpu_context *<noident>
>
> Fix it by declaring it properly.
>
> Signed-off-by: Mukesh Ojha <mojha@...eaurora.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Arnaldo Carvalho de Melo <acme@...nel.org>
> Cc: Jiri Olsa <jolsa@...hat.com>
> Cc: Namhyung Kim <namhyung@...nel.org>
>
> ---
>   include/linux/perf_event.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index 53c500f..1d5c551 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -262,8 +262,8 @@ struct pmu {
>   	 */
>   	int				capabilities;
>   
> -	int * __percpu			pmu_disable_count;
> -	struct perf_cpu_context * __percpu pmu_cpu_context;
> +	int __percpu			*pmu_disable_count;
> +	struct perf_cpu_context __percpu *pmu_cpu_context;
>   	atomic_t			exclusive_cnt; /* < 0: cpu; > 0: tsk */
>   	int				task_ctx_nr;
>   	int				hrtimer_interval_ms;