linux-kernel - Re: [PATCH] USB: quirks: add NO_LPM quirk for Logitech Rally Camera

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20181205093507.GC1817@kroah.com>
Date:   Wed, 5 Dec 2018 10:35:07 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Kyle Williams <kdgwill@...omium.org>
Cc:     Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Rajat Jain <rajatja@...omium.org>,
        Harry Pan <harry.pan@...el.com>,
        Julius Werner <jwerner@...omium.org>,
        Daniel Drake <drake@...lessm.com>,
        Maxence Duprès <xpros64@...mail.fr>,
        Dmitry Fleytman Dmitry Fleytman <dmitry.fleytman@...il.com>,
        Danilo Krummrich <danilokrummrich@...develop.de>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: quirks: add NO_LPM quirk for Logitech Rally Camera

On Thu, Nov 29, 2018 at 07:59:09AM -0500, Kyle Williams wrote:
> Description: Some USB device / host controller combinations seem to have
> problems with Link Power management. In particular it is described that
> the combination of a Logitech Rally and Atrus device causes
> 'not enough bandwidth for new device state'error
> 
> This patch creates quirk entries for the Logitech Rally Camera
> indicating LPM should remain disabled for the device.
> 
> Signed-off-by: Kyle Williams <kdgwill@...omium.org>
> Reviewed-on: https://chromium-review.googlesource.com/1297535
> Commit-Ready: Kyle Williams <kdgwill@...omium.org>
> Tested-by: Kyle Williams <kdgwill@...omium.org>
> Reviewed-by: Julius Werner <jwerner@...omium.org>
> ---
>  drivers/usb/core/quirks.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 2deac3a55957..49c44d89a394 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -224,6 +224,11 @@ static const struct usb_device_id usb_quirk_list[] = {
>   /* Logitech Logitech Screen Share */
>   { USB_DEVICE(0x046d, 0x086c), .driver_info = USB_QUIRK_NO_LPM },
> 
> + /* Logitech Rally Camera */
> + { USB_DEVICE(0x046d, 0x0881), .driver_info = USB_QUIRK_NO_LPM },
> + { USB_DEVICE(0x046d, 0x0888), .driver_info = USB_QUIRK_NO_LPM },
> + { USB_DEVICE(0x046d, 0x0889), .driver_info = USB_QUIRK_NO_LPM },
> +
>   /* Logitech Quickcam Fusion */
>   { USB_DEVICE(0x046d, 0x08c1), .driver_info = USB_QUIRK_RESET_RESUME },
> 

This patch had all tabs stripped out of it, and was sent in html :(