linux-kernel - Re: [PATCH RFC 12/15] inotify: replace **** with a hug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181205094913.GC22304@quack2.suse.cz>
Date:   Wed, 5 Dec 2018 10:49:13 +0100
From:   Jan Kara <jack@...e.cz>
To:     Amir Goldstein <amir73il@...il.com>
Cc:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Jan Kara <jack@...e.cz>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH RFC 12/15] inotify: replace **** with a hug

On Sat 01-12-18 08:40:25, Amir Goldstein wrote:
> On Fri, Nov 30, 2018 at 9:27 PM Jarkko Sakkinen
> <jarkko.sakkinen@...ux.intel.com> wrote:
> >
> > In order to comply with the CoC, replace **** with a hug.
> >
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> > ---
> >  fs/notify/inotify/inotify_user.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c
> > index 105576daca4a..db0b3b6d6a58 100644
> > --- a/fs/notify/inotify/inotify_user.c
> > +++ b/fs/notify/inotify/inotify_user.c
> > @@ -446,7 +446,7 @@ static void inotify_remove_from_idr(struct fsnotify_group *group,
> >         /*
> >          * We found an mark in the idr at the right wd, but it's
> >          * not the mark we were told to remove.  eparis seriously
> > -        * fucked up somewhere.
> > +        * hugged up somewhere.
> >          */
> >         if (unlikely(found_i_mark != i_mark)) {
> >                 WARN_ONCE(1, "%s: i_mark=%p i_mark->wd=%d i_mark->group=%p "
> 
> 
> LoL. doesn't shaming conflict with the CoC?
> Just remove this sentence - it adds no valuable information.
> While at it, please fix grammar "a mark".

Agreed, just send a patch to remove that sentence and fixup the article.
Btw, for the fun of it Eric has added this comment himself so I don't think
this would really qualify as a CoC violation ;)

								Honza

-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR