linux-kernel - Re: [PATCH v2 00/22] mfd: demodularization of non-modular drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181205113535.GX16508@imbe.wolfsonmicro.main>
Date:   Wed, 5 Dec 2018 11:35:35 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
CC:     Lee Jones <lee.jones@...aro.org>, <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Cory Maccarrone <darkstar6262@...il.com>,
        David Dajun Chen <dchen@...semi.com>,
        Dong Aisheng <dong.aisheng@...aro.org>,
        Eric Miao <eric.miao@...vell.com>,
        Graeme Gregory <gg@...mlogic.co.uk>,
        Guennadi Liakhovetski <g.liakhovetski@....de>,
        Haojian Zhuang <haojian.zhuang@...vell.com>,
        Jin Park <jinyoungp@...dia.com>,
        Jorge Eduardo Candelaria <jedu@...mlogic.co.uk>,
        Laxman Dewangan <ldewangan@...dia.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Mark Brown <broonie@...nsource.wolfsonmicro.com>,
        Mattias Nilsson <mattias.i.nilsson@...ricsson.com>,
        Michael Hennerich <michael.hennerich@...log.com>,
        Mike Rapoport <mike@...pulab.co.il>,
        Tony Lindgren <tony@...mide.com>,
        Venu Byravarasu <vbyravarasu@...dia.com>,
        <linux-omap@...r.kernel.org>, <patches@...nsource.cirrus.com>,
        Support Opensource <support.opensource@...semi.com>
Subject: Re: [PATCH v2 00/22] mfd: demodularization of non-modular drivers

On Sun, Dec 02, 2018 at 11:23:07PM -0500, Paul Gortmaker wrote:
> The solution to #4 is similar - we delete the ".remove" function and
> the binding into the platform_driver struct.  However, since the same
> ".remove" function could also be triggered by an "unbind" (such as for
> pass-through of a device to a guest instance)  - so we also explicitly
> disable any unbind for the driver.
> 
> The unbind mask allows us to ensure we will see if there was some odd
> corner case out there that was relying on it.  Typically it would be a
> multi-port ethernet card passing a port through to a guest, so a
> sensible use case in MFD drivers seems highly unlikely.  This same
> solution has already been used in multiple other mainline subsystems.
> 

I guess if this is a general direction thing, but it does seem
that module unload is not the only reason one might ever unbind a
driver. So are we sure we want to remove the option to unbind
these drivers? Certainly for testing it is sometimes useful.

Thanks,
Charles