lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2133486.u21R1XiQqC@house>
Date:   Wed, 05 Dec 2018 12:48:53 +0100
From:   Thomas Renninger <trenn@...e.de>
To:     Abhishek Goel <huntbag@...ux.vnet.ibm.com>
Cc:     linux-pm@...r.kernel.org, shuah@...nel.org,
        linux-kernel@...r.kernel.org, ego@...ux.vnet.ibm.com,
        akshay.adiga@...ux.vnet.ibm.com,
        Bharath Thodla <bharath.thodla@...ibm.com>
Subject: Re: [PATCH] cpupower : Auto-completion for cpupower tool

On Wednesday, December 5, 2018 12:31:04 PM CET Abhishek Goel wrote:
> This script adds support for auto-completion for cpupower tool.
> Added support for auto-completion of all the eight commands for
> cpupower tool and their all subsequent sub-commands, wherever
> possible.

>From what I see all changes I proposed in a previous review round
with a "not that broad audience" have been addressed.

I already integrated the patch (slightly different, without functional 
changes) into the latest cpupower sources of our build service and
things work out nice.

Shuah: Can you pick this up for next cpupower submission round, please.

Thanks,

       Thomas

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ