linux-kernel - Re: [PATCH v2 00/22] mfd: demodularization of non-modular drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbaU03uDbHnRuCp0ef2Zzbb4XcAGgUCn=xBfAxuCEciOw@mail.gmail.com>
Date:   Wed, 5 Dec 2018 12:50:51 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Cory Maccarrone <darkstar6262@...il.com>,
        David Dajun Chen <dchen@...semi.com>,
        Dong Aisheng <dong.aisheng@...aro.org>,
        Eric Miao <eric.miao@...vell.com>,
        Graeme Gregory <gg@...mlogic.co.uk>,
        Guennadi Liakhovetski <g.liakhovetski@....de>,
        Haojian Zhuang <haojian.zhuang@...vell.com>,
        jinyoungp@...dia.com,
        Jorge Eduardo Candelaria <jedu@...mlogic.co.uk>,
        Laxman Dewangan <ldewangan@...dia.com>,
        Mark Brown <broonie@...nsource.wolfsonmicro.com>,
        Mattias NILSSON <mattias.i.nilsson@...ricsson.com>,
        Michael Hennerich <michael.hennerich@...log.com>,
        Mike Rapoport <mike@...pulab.co.il>,
        ext Tony Lindgren <tony@...mide.com>,
        Venu Byravarasu <vbyravarasu@...dia.com>,
        Linux-OMAP <linux-omap@...r.kernel.org>,
        patches@...nsource.cirrus.com,
        Support Opensource <support.opensource@...semi.com>
Subject: Re: [PATCH v2 00/22] mfd: demodularization of non-modular drivers

On Mon, Dec 3, 2018 at 5:24 AM Paul Gortmaker
<paul.gortmaker@...driver.com> wrote:

> [v1 --> v2: add some more commits as requested by Lee (MFD maintainer),
>  update the 00/NN text; re-do build and link testing on new linux-next. ]
>
> This group of MFD drivers are all controlled by "bool" Kconfig settings,
> but contain various amounts of largely pointless uses of infrastructure
> related to modular operations, even though they can't be built modular.
>
> We can easily remove/replace all of it.  We are trying to make driver
> code consistent with the Makefiles/Kconfigs that control them.  This
> means not using modular functions/macros for drivers that can never be
> built as a module.  Some of the downfalls this oversight leads to are:

This series:
Acked-by: Linus Walleij <linus.walleij@...aro.org>

IMO it is clearly the right thing to do, moving a whole bunch
of clutter out of the way so we can see clearly and the effect
of getting rid of the <linux/module.h> is a substantial improvement
in its own right.

Yours.
Linus Walleij