linux-kernel - RE: [PATCH 0/2] put_user_page*(): start converting the call sites

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e7cac96b06664c46bde3abe72ecab2ee@AcuMS.aculab.com>
Date:   Wed, 5 Dec 2018 14:08:54 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'John Hubbard' <jhubbard@...dia.com>,
        "'john.hubbard@...il.com'" <john.hubbard@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>
CC:     Jan Kara <jack@...e.cz>, Tom Talpey <tom@...pey.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        Christian Benvenuti <benve@...co.com>,
        "Christoph Hellwig" <hch@...radead.org>,
        Christopher Lameter <cl@...ux.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Dennis Dalessandro <dennis.dalessandro@...el.com>,
        Doug Ledford <dledford@...hat.com>,
        "Jason Gunthorpe" <jgg@...pe.ca>,
        Jerome Glisse <jglisse@...hat.com>,
        Matthew Wilcox <willy@...radead.org>,
        Michal Hocko <mhocko@...nel.org>,
        Mike Marciniszyn <mike.marciniszyn@...el.com>,
        Ralph Campbell <rcampbell@...dia.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>
Subject: RE: [PATCH 0/2] put_user_page*(): start converting the call sites

From: John Hubbard
> Sent: 05 December 2018 01:06
> On 12/4/18 9:10 AM, David Laight wrote:
> > From: john.hubbard@...il.com
> >> Sent: 04 December 2018 00:17
> >>
> >> Summary: I'd like these two patches to go into the next convenient cycle.
> >> I *think* that means 4.21.
> >>
> >> Details
> >>
> >> At the Linux Plumbers Conference, we talked about this approach [1], and
> >> the primary lingering concern was over performance. Tom Talpey helped me
> >> through a much more accurate run of the fio performance test, and now
> >> it's looking like an under 1% performance cost, to add and remove pages
> >> from the LRU (this is only paid when dealing with get_user_pages) [2]. So
> >> we should be fine to start converting call sites.
> >>
> >> This patchset gets the conversion started. Both patches already had a fair
> >> amount of review.
> >
> > Shouldn't the commit message contain actual details of the change?
> >
> 
> Hi David,
> 
> This "patch 0000" is not a commit message, as it never shows up in git log.
> Each of the follow-up patches does have details about the changes it makes.

I think you should still describe the change - at least in summary.

The patch I looked at didn't really...
IIRC it still referred to external links.

> But maybe you are really asking for more background information, which I
> should have added in this cover letter. Here's a start:
> 
> https://lore.kernel.org/r/20181110085041.10071-1-jhubbard@nvidia.com

Yes, but links go stale....

> ...and it looks like this small patch series is not going to work out--I'm
> going to have to fall back to another RFC spin. So I'll be sure to include
> you and everyone on that. Hope that helps.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)