linux-kernel - Re: [PATCH] KEYS: fix parsing invalid pkey info string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181206182625.GA90507@gmail.com>
Date:   Thu, 6 Dec 2018 10:26:26 -0800
From:   Eric Biggers <ebiggers@...nel.org>
To:     keyrings@...r.kernel.org, dhowells@...hat.com
Cc:     linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH] KEYS: fix parsing invalid pkey info string

On Wed, Nov 28, 2018 at 03:20:20PM -0800, Eric Biggers wrote:
> On Sat, Nov 03, 2018 at 10:30:35AM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@...gle.com>
> > 
> > We need to check the return value of match_token() for Opt_err (-1)
> > before doing anything with it.
> > 
> > Reported-by: syzbot+a22e0dc07567662c50bc@...kaller.appspotmail.com
> > Fixes: 00d60fd3b932 ("KEYS: Provide keyctls to drive the new key type ops for asymmetric keys [ver #2]")
> > Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> > ---
> >  security/keys/keyctl_pkey.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/security/keys/keyctl_pkey.c b/security/keys/keyctl_pkey.c
> > index 783978842f13a..987fac8051d70 100644
> > --- a/security/keys/keyctl_pkey.c
> > +++ b/security/keys/keyctl_pkey.c
> > @@ -50,6 +50,8 @@ static int keyctl_pkey_params_parse(struct kernel_pkey_params *params)
> >  		if (*p == '\0' || *p == ' ' || *p == '\t')
> >  			continue;
> >  		token = match_token(p, param_keys, args);
> > +		if (token == Opt_err)
> > +			return -EINVAL;
> >  		if (__test_and_set_bit(token, &token_mask))
> >  			return -EINVAL;
> >  		q = args[0].from;
> > -- 
> > 2.19.1
> 
> Ping.  David, are you planning to apply this?
> 
> - Eric
> 

Ping.