linux-kernel - Re: [PATCH] dma-buf: fix debugfs versus rcu and fence dumping v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <203a629c-995b-c2c3-4938-1c1494747438@amd.com>
Date:   Thu, 6 Dec 2018 18:30:06 +0000
From:   "Koenig, Christian" <Christian.Koenig@....com>
To:     Chris Wilson <chris@...is-wilson.co.uk>,
        "jglisse@...hat.com" <jglisse@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Daniel Vetter <daniel.vetter@...ll.ch>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linaro-mm-sig@...ts.linaro.org" <linaro-mm-sig@...ts.linaro.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Stéphane Marchesin <marcheu@...omium.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>
Subject: Re: [PATCH] dma-buf: fix debugfs versus rcu and fence dumping v2

Am 06.12.18 um 17:58 schrieb Chris Wilson:
> Quoting jglisse@...hat.com (2018-12-06 15:47:04)
>> From: Jérôme Glisse <jglisse@...hat.com>
>>
>> The debugfs take reference on fence without dropping them. Also the
>> rcu section are not well balance. Fix all that ...
> Wouldn't the code be a lot simpler (and a consistent snapshot) if it used
> reservation_object_get_fences_rcu()?

Yeah, thought about that as well.

Or even better move that code into reservation_object.c as 
reservation_object_show_fences() or something like that.

Christian.

> -Chris