linux-kernel - Re: [PATCH] x86/mm/fault: Streamline the fault error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wgOT0DW8a+VNgmrVybY1RJCajjJKskktzfNd1iJfhuV5Q@mail.gmail.com>
Date:   Thu, 6 Dec 2018 12:24:00 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Andrew Lutomirski <luto@...nel.org>
Cc:     Ingo Molnar <mingo@...nel.org>, sean.j.christopherson@...el.com,
        dave.hansen@...ux.intel.com, Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, bp@...en8.de,
        "the arch/x86 maintainers" <x86@...nel.org>,
        Peter Anvin <hpa@...or.com>,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>,
        Rik van Riel <riel@...riel.com>, yu-cheng.yu@...el.com
Subject: Re: [PATCH] x86/mm/fault: Streamline the fault error_code decoder
 some more

On Thu, Dec 6, 2018 at 11:07 AM Andy Lutomirski <luto@...nel.org> wrote:
>
> How do you like the attached patch?

I agree with whoever thought it's odd that "read" is in lower case
when everything else is in upper case.

And honestly, I'd just siggest making the err_text simply have the
real user/kernel difference in it too, using something like

        pr_alert("#PF error: 0x%04lx%s from %s mode\n", error_code, err_txt,
                user_mode(regs) ? "user" : "kernel" );

The "oh, PF_USER and user_mode differs, so let's point that out
explicitly" thing is a good thing regardless.

             Linus