linux-kernel - Re: [PATCH] pcie: portdrv: Fix Unnecessary space before function pointer arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181206204407.GB247703@google.com>
Date:   Thu, 6 Dec 2018 14:44:07 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Benjamin Young <youngcdev@...il.com>
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pcie: portdrv: Fix Unnecessary space before function
 pointer arguments

On Sat, Dec 01, 2018 at 08:07:11AM -0800, Benjamin Young wrote:
> Made spacing more consistent in the code for function pointer
> declarations based on checkpatch.pl
> 
> Signed-off-by: Benjamin Young <youngcdev@...il.com>

Applied to pci/misc for v4.21, thanks!

I also made similar changes to include/linux/pci.h.  For trivial changes
like this I like to fix similar issues in all of PCI at the same time.

> ---
>  drivers/pci/pcie/portdrv.h | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h
> index e495f04..fbbf00b0 100644
> --- a/drivers/pci/pcie/portdrv.h
> +++ b/drivers/pci/pcie/portdrv.h
> @@ -71,19 +71,19 @@ static inline void *get_service_data(struct pcie_device *dev)
>  
>  struct pcie_port_service_driver {
>  	const char *name;
> -	int (*probe) (struct pcie_device *dev);
> -	void (*remove) (struct pcie_device *dev);
> -	int (*suspend) (struct pcie_device *dev);
> -	int (*resume_noirq) (struct pcie_device *dev);
> -	int (*resume) (struct pcie_device *dev);
> -	int (*runtime_suspend) (struct pcie_device *dev);
> -	int (*runtime_resume) (struct pcie_device *dev);
> +	int (*probe)(struct pcie_device *dev);
> +	void (*remove)(struct pcie_device *dev);
> +	int (*suspend)(struct pcie_device *dev);
> +	int (*resume_noirq)(struct pcie_device *dev);
> +	int (*resume)(struct pcie_device *dev);
> +	int (*runtime_suspend)(struct pcie_device *dev);
> +	int (*runtime_resume)(struct pcie_device *dev);
>  
>  	/* Device driver may resume normal operations */
>  	void (*error_resume)(struct pci_dev *dev);
>  
>  	/* Link Reset Capability - AER service driver specific */
> -	pci_ers_result_t (*reset_link) (struct pci_dev *dev);
> +	pci_ers_result_t (*reset_link)(struct pci_dev *dev);
>  
>  	int port_type;  /* Type of the port this driver can handle */
>  	u32 service;    /* Port service this device represents */
> -- 
> 2.5.0
>