linux-kernel - Re: [PATCH] leds: 88pm860x: Use of_node_name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 Dec 2018 22:00:28 +0100
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Pavel Machek <pavel@....cz>, linux-leds@...r.kernel.org
Subject: Re: [PATCH] leds: 88pm860x: Use of_node_name_eq for node name
 comparisons

Hi Rob,

Thank you for the patch.

On 12/5/18 2:50 PM, Rob Herring wrote:
> Convert string compares of DT node names to use of_node_name_eq helper
> instead. This removes direct access to the node name pointer.
> 
> For instances using of_node_cmp, this has the side effect of now using
> case sensitive comparisons. This should not matter for any FDT based
> system which this is.
> 
> Cc: Jacek Anaszewski <jacek.anaszewski@...il.com>
> Cc: Pavel Machek <pavel@....cz>
> Cc: linux-leds@...r.kernel.org
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>   drivers/leds/leds-88pm860x.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/leds-88pm860x.c b/drivers/leds/leds-88pm860x.c
> index 77a104d2b124..036d4a536697 100644
> --- a/drivers/leds/leds-88pm860x.c
> +++ b/drivers/leds/leds-88pm860x.c
> @@ -130,7 +130,7 @@ static int pm860x_led_dt_init(struct platform_device *pdev,
>   		return -ENODEV;
>   	}
>   	for_each_child_of_node(nproot, np) {
> -		if (!of_node_cmp(np->name, data->name)) {
> +		if (of_node_name_eq(np, data->name)) {
>   			of_property_read_u32(np, "marvell,88pm860x-iset",
>   					     &iset);
>   			data->iset = PM8606_LED_CURRENT(iset);
> 

Applied.

-- 
Best regards,
Jacek Anaszewski