linux-kernel - Re: [PATCH] PCI/P2PDMA: Match interface changes to devm_memremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c226426d-e88c-da18-f643-f3faaf1c0dbd@deltatee.com>
Date:   Thu, 6 Dec 2018 15:17:00 -0700
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Linux MM <linux-mm@...ck.org>, linux-pci@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Dan Williams <dan.j.williams@...el.com>
Subject: Re: [PATCH] PCI/P2PDMA: Match interface changes to
 devm_memremap_pages()



On 2018-12-06 1:46 p.m., Bjorn Helgaas wrote:
> On Fri, Nov 30, 2018 at 03:59:11PM -0700, Logan Gunthorpe wrote:
>> "mm-hmm-mark-hmm_devmem_add-add_resource-export_symbol_gpl.patch" in the
>> mm tree breaks p2pdma. The patch was written and reviewed before p2pdma
>> was merged so the necessary changes were not done to the call site in
>> that code.
>>
>> Without this patch, all drivers will fail to register P2P resources
>> because devm_memremap_pages() will return -EINVAL due to the 'kill'
>> member of the pagemap structure not yet being set.
>>
>> Signed-off-by: Logan Gunthorpe <logang@...tatee.com>
>> Cc: Andrew Morton <akpm@...ux-foundation.org>
>> Cc: Dan Williams <dan.j.williams@...el.com>
>> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> Applied with Dan's reviewed-by to pci/peer-to-peer for v4.21, thanks!
> 
> If the mm patch you mention gets merged for v4.20, let me know and I can
> promote this to for-linus so v4.20 doesn't end up broken.

Thanks Bjorn, but I think Andrew has also picked it up in the mm tree
with the patch in question. My hope is that he squashes the two but I'm
not sure what his intentions are. I mostly copied you for  information
purposes as this patch shouldn't even compile without Dan's patch.

Though, I guess we'll find out what goes in after the merge window --
you may not need to do anything.

Logan