linux-kernel - Re: [PATCH 2/3] dt-bindings: drm/panel: simple: add support for PDA 91-00156-A0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181206234550.GA3012@bogus>
Date:   Thu, 6 Dec 2018 17:45:50 -0600
From:   Rob Herring <robh@...nel.org>
To:     Eugen.Hristev@...rochip.com
Cc:     mark.rutland@....com, devicetree@...r.kernel.org,
        thierry.reding@...il.com, airlied@...ux.ie,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, Nicolas.Ferre@...rochip.com,
        Cristian.Birsan@...rochip.com
Subject: Re: [PATCH 2/3] dt-bindings: drm/panel: simple: add support for PDA
 91-00156-A0

On Wed, Nov 21, 2018 at 08:48:00AM +0000, Eugen.Hristev@...rochip.com wrote:
> From: Cristian Birsan <cristian.birsan@...rochip.com>
> 
> PDA 91-00156-A0 5.0 is a 5.0" WVGA TFT LCD panel.
> This panel with backlight is found in PDA 5" LCD screen (TM5000 series or
> AC320005-5).
> Adding Device Tree bindings for this panel.
> 
> Signed-off-by: Cristian Birsan <cristian.birsan@...rochip.com>
> ---
>  .../devicetree/bindings/display/panel/pda,91-00156-a0.txt          | 7 +++++++
>  1 file changed, 7 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.txt b/Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.txt
> new file mode 100644
> index 0000000..52f0da9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.txt
> @@ -0,0 +1,7 @@
> +PDA 91-00156-A0 5.0" WVGA TFT LCD panel
> +
> +Required properties:
> +- compatible: should be "pda,91-00156-a0"
> +
> +This binding is compatible with the simple-panel binding, which is specified
> +in simple-panel.txt in this directory.

You need to explicitly list what properties from this are used. Does 
this have a single supply or did you just forget to add supplies for 
example? I don't know.

Rob