linux-kernel - Re: [PATCH 0/5 v7] Keep rtsx_usb suspended when there's no card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFpoNY_zvX6dahdFEutYryxPSWAV0H_9tWsVkvgUbsvvzA@mail.gmail.com>
Date:   Thu, 6 Dec 2018 09:57:40 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Kai Heng Feng <kai.heng.feng@...onical.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux USB List <linux-usb@...r.kernel.org>,
        Alan Stern <stern@...land.harvard.edu>,
        Oleksandr Natalenko <oleksandr@...alenko.name>
Subject: Re: [PATCH 0/5 v7] Keep rtsx_usb suspended when there's no card

On Fri, 23 Nov 2018 at 13:21, Ulf Hansson <ulf.hansson@...aro.org> wrote:
>
> On Fri, 23 Nov 2018 at 07:06, Kai Heng Feng <kai.heng.feng@...onical.com> wrote:
> >
> > Hi Ulf,
> >
> > > On Nov 8, 2018, at 8:17 PM, Oleksandr Natalenko <oleksandr@...alenko.name> wrote:
> > >
> > >> This is based on Ulf's work [1] [2].
> > >> This patch series can keep rtsx_usb suspended, to save ~0.5W on Intel
> > >> platforms and ~1.5W on AMD platforms.
> > >> [1] https://patchwork.kernel.org/patch/10440583/
> > >> [2] https://patchwork.kernel.org/patch/10445725/
> > >
> > > Tested-by: Oleksandr Natalenko <oleksandr@...alenko.name>
> >
> > Do you think this series is ready to be merged to v4.20?
>
> I have had a brief look at the latest version a while ago, looked
> good. However, allow a few more days before I can give it my final
> blessing.
>
> BTW. We need to figure out what path to route the changes through. I
> can pick it via my mmc tree, unless someone object to that.

Okay, so I have picked up the patches and applied them to my next
branch to my mmc tree. While doing that, I have also added Oleksandr's
tested-by tag for all patches, including the four mmc patches. I also
added your tested-by tags to the the four mmc patches.

Finally I made little cosmetic change to last patch in this series,
which was dropping the surrounding #ifdef CONFIG_PM while do the
assignment of .driver.pm to &rtsx_usb_ms_pm_ops, as that isn't needed.

If anybody have any objections, please tell me.

Kind regards
Uffe