linux-kernel - [PATCH] tps65218.c: fix IRQ resource leak in tps65218

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1544090279-26762-1-git-send-email-Christian.Hohnstaedt@wago.com>
Date:   Thu, 6 Dec 2018 10:57:59 +0100
From:   Christian Hohnstaedt <Christian.Hohnstaedt@...o.com>
To:     "J, KEERTHY" <j-keerthy@...com>, Lee Jones <lee.jones@...aro.org>
CC:     <linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>
Subject: [PATCH] tps65218.c: fix IRQ resource leak in tps65218_probe()

Free allocated IRQ if reading the device ID fails.

Signed-off-by: Christian Hohnstaedt <Christian.Hohnstaedt@...o.com>
---
 drivers/mfd/tps65218.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/tps65218.c b/drivers/mfd/tps65218.c
index 910f569..19270bc 100644
--- a/drivers/mfd/tps65218.c
+++ b/drivers/mfd/tps65218.c
@@ -244,7 +244,7 @@ static int tps65218_probe(struct i2c_client *client,
 	ret = regmap_read(tps->regmap, TPS65218_REG_CHIPID, &chipid);
 	if (ret) {
 		dev_err(tps->dev, "Failed to read chipid: %d\n", ret);
-		return ret;
+		goto err_irq;
 	}
 
 	tps->rev = chipid & TPS65218_CHIPID_REV_MASK;
-- 
2.7.4