linux-kernel - Re: [PATCH] kref/kobject: Improve documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181206125730.GA30398@kroah.com>
Date:   Thu, 6 Dec 2018 13:57:30 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Ezequiel Garcia <ezequiel@...labora.com>
Cc:     linux-kernel@...r.kernel.org,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        kernel@...labora.com,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Gustavo Padovan <gustavo.padovan@...labora.com>,
        Matthias Brugger <mbrugger@...e.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH] kref/kobject: Improve documentation

On Mon, Dec 03, 2018 at 01:44:35PM -0300, Ezequiel Garcia wrote:
> The current kref and kobject documentation may be
> insufficient to understand these common pitfalls regarding
> object lifetime and object releasing.
> 
> Add a bit more documentation and improve the warnings
> seen by the user, pointing to the right piece of documentation.
> 
> Also, it's important to understand that making fun of people
> publicly is not at all helpful, doesn't provide any value,
> and it's not a healthy way of encouraging developers to do better.
> 
> "Mocking mercilessly" will, if anything, make developers feel bad
> and go away. This kind of behavior should not be encouraged or justified.

Very true, thanks for fixing this up and providing a much better wording
for all of this, including the warning messages.

Now queued up, thanks.

greg k-h