linux-kernel - Re: [PATCH v2] driver core: platform: Respect return code of platform_device_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VfgNv1hGB9zwXXkwuaVAqLhj0jo7qwh=0G-VuF1S2gSBQ@mail.gmail.com>
Date:   Thu, 6 Dec 2018 15:24:29 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Subject: Re: [PATCH v2] driver core: platform: Respect return code of platform_device_register_full()

On Thu, Dec 6, 2018 at 2:59 PM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> On Mon, Dec 03, 2018 at 08:21:41PM +0200, Andy Shevchenko wrote:
> > The platform_device_register_full() might return an error pointer. If we
> > instantiate platform device which is optional we may simplify the routine at
> > removal stage by simply calling platform_device_unregister(). For now it
> > requires to check parameter for being an error pointer in each caller.
> >
> > To make users' life easier, check for an error pointer inside driver core.
> >
> > Reported-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > ---
> > - rebase on top of linux-next since the conflicting patch has been applied there
>
> What conflicting patch?  This now doesn't apply to my tree.

One patch from Heikki had been applied earlier, I rebased and sent v2
at the same day as this one.

>
> Let me fix it up by hand...
>


-- 
With Best Regards,
Andy Shevchenko