linux-kernel - Re: [PATCH][next] drivers: base: remove need for a temporary string for the node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 Dec 2018 16:23:30 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Colin Ian King <colin.king@...onical.com>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        kernel-janitors@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Subject: Re: [PATCH][next] drivers: base: remove need for a temporary string
 for the node name

On Thu, Dec 6, 2018 at 3:57 PM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> On Thu, Nov 29, 2018 at 06:08:44PM +0000, Colin King wrote:
> > From: Colin Ian King <colin.king@...onical.com>
> >
> > Currently the node name is being formatting into a temporary string
> > node_name, however, kobject_init_and_add allows one to format up
> > a node name, so use that instead. This removes the need for the
> > node_name string and also cleans up the following warning:
> >
> > Fixes clang warning:
> > warning: format string is not a string literal (potentially
> > insecure) [-Wformat-security]
> >
> > Signed-off-by: Colin Ian King <colin.king@...onical.com>
> > ---
> >  drivers/base/swnode.c | 5 +----
>
> I don't know where this file comes from.  It's not in my
> driver-core-next branch, who is creating it?

It is in my linux-next one, comes from a series of device properties
patches by Heikki (CCed to you).

This is the patch adding it: https://patchwork.kernel.org/patch/10676063/

So Colin, please resend and CC linux-acpi@...r.kernel.org.