linux-kernel - Re: [PATCH 1/8] lib/lzo: tidy-up ifdefs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5C094506.7040501@oberhumer.com>
Date:   Thu, 6 Dec 2018 16:49:26 +0100
From:   "Markus F.X.J. Oberhumer" <markus@...rhumer.com>
To:     Dave Rodgman <dave.rodgman@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
Cc:     "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Matt Sealey <Matt.Sealey@....com>,
        "nitingupta910@...il.com" <nitingupta910@...il.com>,
        "minchan@...nel.org" <minchan@...nel.org>,
        "sergey.senozhatsky.work@...il.com" 
        <sergey.senozhatsky.work@...il.com>,
        "sonnyrao@...gle.com" <sonnyrao@...gle.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        nd <nd@....com>, "sfr@...b.auug.org.au" <sfr@...b.auug.org.au>
Subject: Re: [PATCH 1/8] lib/lzo: tidy-up ifdefs

Acked-by: Markus F.X.J. Oberhumer <markus@...rhumer.com>


On 2018-11-30 15:26, Dave Rodgman wrote:
> Modify the ifdefs in lzodefs.h to be more consistent with normal kernel
> macros (e.g., change __aarch64__ to CONFIG_ARM64).
> 
> Signed-off-by: Dave Rodgman <dave.rodgman@....com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Nitin Gupta <nitingupta910@...il.com>
> Cc: Richard Purdie <rpurdie@...nedhand.com>
> Cc: Markus F.X.J. Oberhumer <markus@...rhumer.com>
> Cc: Minchan Kim <minchan@...nel.org>
> Cc: Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
> Cc: Sonny Rao <sonnyrao@...gle.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Matt Sealey <matt.sealey@....com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
> ---
>  lib/lzo/lzodefs.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/lzo/lzodefs.h b/lib/lzo/lzodefs.h
> index 4edefd2f540c..497f9c9f03a8 100644
> --- a/lib/lzo/lzodefs.h
> +++ b/lib/lzo/lzodefs.h
> @@ -15,7 +15,7 @@
>  
>  #define COPY4(dst, src)	\
>  		put_unaligned(get_unaligned((const u32 *)(src)), (u32 *)(dst))
> -#if defined(__x86_64__)
> +#if defined(CONFIG_X86_64)
>  #define COPY8(dst, src)	\
>  		put_unaligned(get_unaligned((const u64 *)(src)), (u64 *)(dst))
>  #else
> @@ -25,12 +25,12 @@
>  
>  #if defined(__BIG_ENDIAN) && defined(__LITTLE_ENDIAN)
>  #error "conflicting endian definitions"
> -#elif defined(__x86_64__)
> +#elif defined(CONFIG_X86_64)
>  #define LZO_USE_CTZ64	1
>  #define LZO_USE_CTZ32	1
> -#elif defined(__i386__) || defined(__powerpc__)
> +#elif defined(CONFIG_X86) || defined(CONFIG_PPC)
>  #define LZO_USE_CTZ32	1
> -#elif defined(__arm__) && (__LINUX_ARM_ARCH__ >= 5)
> +#elif defined(CONFIG_ARM) && (__LINUX_ARM_ARCH__ >= 5)
>  #define LZO_USE_CTZ32	1
>  #endif
>  
> 

-- 
Markus Oberhumer, <markus@...rhumer.com>, http://www.oberhumer.com/