linux-kernel - Re: [PATCH] scripts/atomic: change 'fold' to 'grep'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181206155244.GA4389@arm.com>
Date:   Thu, 6 Dec 2018 15:52:44 +0000
From:   Will Deacon <will.deacon@....com>
To:     Anders Roxell <anders.roxell@...aro.org>, mingo@...nel.org
Cc:     peterz@...radead.org, linux-kernel@...r.kernel.org,
        mark.rutland@....com
Subject: Re: [PATCH] scripts/atomic: change 'fold' to 'grep'

[+ Ingo and Mark]

On Tue, Dec 04, 2018 at 10:47:13PM +0100, Anders Roxell wrote:
> Some distibutions and build systems doesn't include 'fold' from
> coreutils default.
> 
> .../scripts/atomic/atomic-tbl.sh: line 183: fold: command not found
> 
> Rework to use 'grep' instead of 'fold' to use a dependency that is
> already used a lot in the kernel.
> 
> Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> Suggested-by: Will Deacon <will.deacon@....com>
> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
> ---
>  scripts/atomic/atomic-tbl.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/atomic/atomic-tbl.sh b/scripts/atomic/atomic-tbl.sh
> index 9d6be538a987..81d5c32039dd 100755
> --- a/scripts/atomic/atomic-tbl.sh
> +++ b/scripts/atomic/atomic-tbl.sh
> @@ -180,7 +180,7 @@ gen_proto_variants()
>  #gen_proto(meta, ...)
>  gen_proto() {
>  	local meta="$1"; shift
> -	for m in $(echo "${meta}" | fold -w1); do
> +	for m in $(echo "${meta}" | grep -o .); do
>  		gen_proto_variants "${m}" "$@"
>  	done

Acked-by: Will Deacon <will.deacon@....com>

Ingo -- please can you take this one via -tip?

Cheers,

Will