lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20181206162340.GA12032@kroah.com>
Date:   Thu, 6 Dec 2018 17:23:40 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Bryan O'Donoghue <pure.logic@...us-software.ie>
Cc:     Sicilia Cristian <sicilia.cristian@...il.com>,
        devel@...verdev.osuosl.org, Alex Elder <elder@...nel.org>,
        Johan Hovold <johan@...nel.org>, linux-kernel@...r.kernel.org,
        greybus-dev@...ts.linaro.org
Subject: Re: [PATCH 2/2] staging: greybus: Added space between string
 concatenated

On Thu, Dec 06, 2018 at 04:14:53PM +0000, Bryan O'Donoghue wrote:
> On 06/12/2018 15:05, Greg Kroah-Hartman wrote:
> > On Thu, Dec 06, 2018 at 09:43:46AM +0000, Bryan O'Donoghue wrote:
> > > On 05/12/2018 21:00, Sicilia Cristian wrote:
> > > > It doesn't change the result string
> > > 
> > > So why do it then ?
> > 
> > Because it is easier to read this way and odds are checkpatch is
> > happier.
> 
> Fine.
> 
> Sicilia could you please amend your commit.
> 
> 'This patch fixes the checkpatch error "CHECK: Concatenated strings should
> use spaces between elements"'
> 
> and then feel free to add my
> 
> Acked-by: Bryan O'Donoghue <pure.logic@...us-software.ie>

It's already in my tree, no need to ammend it, sorry :)

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ