linux-kernel - Re: [PATCH] riscv: remove unused variable in ftrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181206200743.0f951d19@vmware.local.home>
Date:   Thu, 6 Dec 2018 20:07:43 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Olof Johansson <olof@...om.net>
Cc:     David Abdurachmanov <david.abdurachmanov@...il.com>,
        Palmer Dabbelt <palmer@...ive.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        linux-riscv@...ts.infradead.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] riscv: remove unused variable in ftrace

On Thu, 6 Dec 2018 11:20:31 -0800
Olof Johansson <olof@...om.net> wrote:

> On Thu, Dec 6, 2018 at 2:26 AM David Abdurachmanov
> <david.abdurachmanov@...il.com> wrote:
> >
> > Noticed while building kernel-4.20.0-0.rc5.git2.1.fc30 for
> > Fedora 30/RISCV.
> >
> > [..]
> > BUILDSTDERR: arch/riscv/kernel/ftrace.c: In function 'prepare_ftrace_return':
> > BUILDSTDERR: arch/riscv/kernel/ftrace.c:135:6: warning: unused variable 'err' [-Wunused-variable]
> > BUILDSTDERR:   int err;
> > BUILDSTDERR:       ^~~

Bah. I could have sworn I checked for all the error messages when I did
my cross-compiling of the architectures. I fixed this issue in other
places, not sure how I missed riscv.

Thanks for fixing it.

Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve

 
> > [..]
> >
> > Signed-off-by: David Abdurachmanov <david.abdurachmanov@...il.com>  
> 
> Please add a:
> Fixes: e949b6db51dc1 ("riscv/function_graph: Simplify with
> function_graph_enter()")
> Reviewed-by: Olof Johansson <olof@...om.net>