linux-kernel - Re: [PATCH 2/5] media: dt-bindings: Add binding for si470x radio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c8bb6ef-5f37-69ef-6829-a9e9ad04579b@xs4all.nl>
Date:   Fri, 7 Dec 2018 12:33:10 +0100
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Paweł Chmiel <pawel.mikolaj.chmiel@...il.com>,
        mchehab@...nel.org, robh+dt@...nel.org, mark.rutland@....com
Cc:     fischerdouglasc@...il.com, keescook@...omium.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 2/5] media: dt-bindings: Add binding for si470x radio

Please combine 2/5 with 5/5. No need to have two patches for these bindings.

Regards,

	Hans

On 12/05/2018 04:47 PM, Paweł Chmiel wrote:
> Add device tree bindings for si470x family radio receiver driver.
> 
> Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@...il.com>
> ---
>  .../devicetree/bindings/media/si470x.txt      | 24 +++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/si470x.txt
> 
> diff --git a/Documentation/devicetree/bindings/media/si470x.txt b/Documentation/devicetree/bindings/media/si470x.txt
> new file mode 100644
> index 000000000000..9294fdfd3aae
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/si470x.txt
> @@ -0,0 +1,24 @@
> +* Silicon Labs FM Radio receiver
> +
> +The Silicon Labs Si470x is family of FM radio receivers with receive power scan
> +supporting 76-108 MHz, programmable through an I2C interface.
> +Some of them includes an RDS encoder.
> +
> +Required Properties:
> +- compatible: Should contain "silabs,si470x"
> +- reg: the I2C address of the device
> +
> +Optional Properties:
> +- interrupts : The interrupt number
> +
> +Example:
> +
> +&i2c2 {
> +        si470x@63 {
> +                compatible = "silabs,si470x";
> +                reg = <0x63>;
> +
> +                interrupt-parent = <&gpj2>;
> +                interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
> +        };
> +};
>