linux-kernel - Re: [PATCH v3 2/2] kobject: drop newline from msg string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181207120405.GC15336@kroah.com>
Date:   Fri, 7 Dec 2018 13:04:05 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Bo YU <tsu.yubo@...il.com>
Cc:     rafael@...nel.org, linux-kernel@...r.kernel.org, joe@...ches.com,
        yuzibode@....com
Subject: Re: [PATCH v3 2/2] kobject: drop newline from msg string

On Fri, Dec 07, 2018 at 05:21:49AM -0500, Bo YU wrote:
> There is currently a missing terminating newline in non-switch case
> match, when msg == NULL.
> 
> Signed-off-by: Bo YU <tsu.yubo@...il.com>
> ---
> Changes in v3:
> Improve the commit log,requested by rafael.
> 
> Changes in v2:
> According to Joe's suggestion,drop newline from msg
> 
>  lib/kobject_uevent.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
> index b7c088c902a2..1837765ebf01 100644
> --- a/lib/kobject_uevent.c
> +++ b/lib/kobject_uevent.c
> @@ -195,12 +195,12 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
>  	enum kobject_action action;
>  	const char *action_args;
>  	struct kobj_uevent_env *env;
> -	const char *msg = NULL, *devpath;
> +	const char *msg = NULL;

Why did you move the devpath variable from here to lower down?  That
really doesn't do anything :(

thanks,

greg k-h