linux-kernel - Re: [PATCH v2] mtd: rawnand: jz4780: annotate implicit fall throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181207195107.1b4959e1@xps13>
Date:   Fri, 7 Dec 2018 19:51:07 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Mathieu Malaterre <malat@...ian.org>
Cc:     Paul Burton <paul.burton@...s.com>, trivial@...nel.org,
        kernel-janitors@...r.kernel.org,
        Harvey Hunt <harveyhuntnexus@...il.com>,
        Boris Brezillon <boris.brezillon@...tlin.com>,
        Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Marek Vasut <marek.vasut@...il.com>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mtd: rawnand: jz4780: annotate implicit fall
 throughs

Hi Mathieu,

Mathieu Malaterre <malat@...ian.org> wrote on Tue,  4 Dec 2018 21:10:57
+0100:

> There is a plan to build the kernel with -Wimplicit-fallthrough and
> these places in the code produced warnings. Fix them up.
> 
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
> ---
> v2: fix subject prefix non sense
> 
>  drivers/mtd/nand/raw/jz4780_bch.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/nand/raw/jz4780_bch.c b/drivers/mtd/nand/raw/jz4780_bch.c
> index 731c6051d91e..7201827809e9 100644
> --- a/drivers/mtd/nand/raw/jz4780_bch.c
> +++ b/drivers/mtd/nand/raw/jz4780_bch.c
> @@ -136,8 +136,10 @@ static void jz4780_bch_read_parity(struct jz4780_bch *bch, void *buf,
>  	switch (size8) {
>  	case 3:
>  		dest8[2] = (val >> 16) & 0xff;
> +		/* fall through */
>  	case 2:
>  		dest8[1] = (val >> 8) & 0xff;
> +		/* fall through */
>  	case 1:
>  		dest8[0] = val & 0xff;
>  		break;

Applied to nand/next.


Thanks,
Miquèl