linux-kernel - RE: [PATCH V5 2/2] thermal: imx: save one condition block for normal case of nvmem initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 7 Dec 2018 03:11:31 +0000
From:   Anson Huang <anson.huang@....com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        "rui.zhang@...el.com" <rui.zhang@...el.com>,
        "edubezval@...il.com" <edubezval@...il.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "viresh.kumar@...aro.org" <viresh.kumar@...aro.org>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>
CC:     dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH V5 2/2] thermal: imx: save one condition block for normal
 case of nvmem initialization

Gentle ping..

Best Regards!
Anson Huang

> -----Original Message-----
> From: Daniel Lezcano [mailto:daniel.lezcano@...aro.org]
> Sent: 2018年11月21日 16:31
> To: Anson Huang <anson.huang@....com>; rui.zhang@...el.com;
> edubezval@...il.com; linux-pm@...r.kernel.org;
> linux-kernel@...r.kernel.org; viresh.kumar@...aro.org;
> l.stach@...gutronix.de
> Cc: dl-linux-imx <linux-imx@....com>
> Subject: Re: [PATCH V5 2/2] thermal: imx: save one condition block for normal
> case of nvmem initialization
> 
> On 21/11/2018 06:49, Anson Huang wrote:
> > Put return value checks of calling imx_init_from_nvmem_cells() into
> > one block to save one condition block for normal case.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@....com>
> 
> Reviewed-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> 
> > ---
> >  drivers/thermal/imx_thermal.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/thermal/imx_thermal.c
> > b/drivers/thermal/imx_thermal.c index c924396..bb6754a 100644
> > --- a/drivers/thermal/imx_thermal.c
> > +++ b/drivers/thermal/imx_thermal.c
> > @@ -742,9 +742,10 @@ static int imx_thermal_probe(struct
> > platform_device *pdev)
> >
> >  	if (of_find_property(pdev->dev.of_node, "nvmem-cells", NULL)) {
> >  		ret = imx_init_from_nvmem_cells(pdev);
> > -		if (ret == -EPROBE_DEFER)
> > -			return ret;
> >  		if (ret) {
> > +			if (ret == -EPROBE_DEFER)
> > +				return ret;
> > +
> >  			dev_err(&pdev->dev, "failed to init from nvmem: %d\n",
> >  				ret);
> >  			return ret;
> >
> 
> 
> --
> 
> <https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww
> .linaro.org%2F&amp;data=02%7C01%7Canson.huang%40nxp.com%7Cfd6043
> 7ee3644bef859308d64f8babfc%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C
> 0%7C0%7C636783858654973865&amp;sdata=BgscGAsKYemJsPxOeWnhK9o7
> 2DnyV%2B5p%2B%2F2FukhcpqM%3D&amp;reserved=0> Linaro.org │ Open
> source software for ARM SoCs
> 
> Follow Linaro:
> <https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww
> .facebook.com%2Fpages%2FLinaro&amp;data=02%7C01%7Canson.huang%40
> nxp.com%7Cfd60437ee3644bef859308d64f8babfc%7C686ea1d3bc2b4c6fa92
> cd99c5c301635%7C0%7C0%7C636783858654973865&amp;sdata=6zA10lW
> wnWoAUK7jqqvsDDMM2Q13AedmeSPABMeR%2Bxc%3D&amp;reserved=0>
> Facebook |
> <https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Ftwitt
> er.com%2F%23!%2Flinaroorg&amp;data=02%7C01%7Canson.huang%40nxp.c
> om%7Cfd60437ee3644bef859308d64f8babfc%7C686ea1d3bc2b4c6fa92cd99
> c5c301635%7C0%7C0%7C636783858654973865&amp;sdata=kuquKEUuvXW
> 88V2QgPQgXYBgv2Htv37GKDqah0VeIJ8%3D&amp;reserved=0> Twitter |
> <https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww
> .linaro.org%2Flinaro-blog%2F&amp;data=02%7C01%7Canson.huang%40nxp.c
> om%7Cfd60437ee3644bef859308d64f8babfc%7C686ea1d3bc2b4c6fa92cd99
> c5c301635%7C0%7C0%7C636783858654973865&amp;sdata=0AiYcj1H1va1n
> mee2tHWWYnmGe5wzFoao4KZbkxsKzo%3D&amp;reserved=0> Blog