linux-kernel - Re: [PATCH] USB: quirks: add NO_LPM quirk for Logitech Flare|Meetup|Brio|Rally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Dec 2018 17:21:38 -0500
From:   Kyle Williams <kdgwill@...omium.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-usb@...r.kernel.org,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Alan Stern <stern@...land.harvard.edu>,
        Jack Stocker <jackstocker.93@...il.com>,
        Michael Niewöhner <linux@...ewoehner.de>,
        Nico Sneck <snecknico@...il.com>,
        Tim Anderson <tsa@...lakesoftware.com>,
        Danilo Krummrich <danilokrummrich@...develop.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: quirks: add NO_LPM quirk for Logitech
 Flare|Meetup|Brio|Rally

On Wed, Dec 05, 2018 at 10:39:02AM +0100, Greg Kroah-Hartman wrote:
> On Tue, Dec 04, 2018 at 03:38:25PM -0500, Kyle Williams wrote:
> > Description: Some USB device / host controller combinations seem to have
> > problems with Link Power management. In particular it is described that
> > the combination of certain Logitech devices and other powered media
> > devices such as the Atrus device causes 'not enough bandwidth for
> > new device state'error.
> > 
> > This patch creates quirk entries for the tested Logitech device
> > indicating LPM should remain disabled for the device.
> > 
> > Signed-off-by: Kyle Williams <kdgwill@...omium.org>
> > ---
> >  drivers/usb/core/quirks.c | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> 
> Along with what Alan said, this patch was sent in html mode, making it
> impossible to apply, and it was rejected by the mailing lists.
> 
> Please fix up your email client before resending patches.  Or just use
> 'git send-email'.
> 
> thanks,
> 
> greg k-h

Thanks for explaining why the patches were being rejected by the mailing
lists. I will move to using git send-email for sending patches and mutt
for sending replies in the future.

Kyle Williams