linux-kernel - [PATCH v3 2/2] USB: quirks: Disable LPM for Logitech UVC devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181208014724.951-3-kdgwill@google.com>
Date:   Fri,  7 Dec 2018 20:47:22 -0500
From:   Kyle Williams <kdgwill@...omium.org>
To:     linux-kernel@...r.kernel.org
Cc:     kdgwill@...omium.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alan Stern <stern@...land.harvard.edu>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Nicolas Boichat <drinkcat@...omium.org>,
        Jon Flatley <jflat@...omium.org>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>,
        Harry Pan <harry.pan@...el.com>,
        Emmanuel Pescosta <emmanuelpescosta099@...il.com>,
        Danilo Krummrich <danilokrummrich@...develop.de>,
        Dmitry Fleytman Dmitry Fleytman <dmitry.fleytman@...il.com>,
        linux-usb@...r.kernel.org
Subject: [PATCH v3 2/2] USB: quirks: Disable LPM for Logitech UVC devices

From: Kyle Williams <kdgwill@...omium.org>

Description: Some USB device / host controller combinations seem to have
problems with Link Power management. In particular it is described that
the combination of certain Logitech uvc devices and other powered media
devices such causes 'not enough bandwidth for new device state' error.

This patch enables the USB_QUIRK_NO_LPM quirk entries for all connected
Logitech UVC devices indicating LPM should remain disabled for the device.

Signed-off-by: Kyle Williams <kdgwill@...omium.org>
---
 drivers/usb/core/quirks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 0690fcff0ea2..bbbb7e6df958 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -440,7 +440,7 @@ static const struct usb_device_id usb_quirk_list[] = {
 static const struct usb_device_id usb_interface_quirk_list[] = {
 	/* Logitech UVC Cameras */
 	{ USB_VENDOR_AND_INTERFACE_INFO(0x046d, USB_CLASS_VIDEO, 1, 0),
-	  .driver_info = USB_QUIRK_RESET_RESUME },
+	  .driver_info = USB_QUIRK_RESET_RESUME | USB_QUIRK_NO_LPM },
 
 	{ }  /* terminating entry must be last */
 };
-- 
2.20.0.rc2.403.gdbc3b29805-goog