linux-kernel - Re: [PATCH] Watchdog: remove outdated comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <18f7e9ee-0d8f-7c73-cdc0-7826e912d33a@roeck-us.net>
Date:   Sun, 9 Dec 2018 06:13:59 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Hardik Singh Rathore <hardiksingh.k@...il.com>
Cc:     wim@...ux-watchdog.org, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Watchdog: remove outdated comment

On 12/9/18 2:47 AM, Hardik Singh Rathore wrote:
> The lock field doesn't exist in watchdog_device structure.
> It was added by commit f4e9c82f64b5 ("watchdog: Add Locking support")
> and removed by commit b4ffb1909843
> ("watchdog: Separate and maintain variables based on variable lifetime")
> 
> Signed-off-by: Hardik Singh Rathore <hardiksingh.k@...il.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   include/linux/watchdog.h | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/include/linux/watchdog.h b/include/linux/watchdog.h
> index 44985c4a1e86..417d9f37077a 100644
> --- a/include/linux/watchdog.h
> +++ b/include/linux/watchdog.h
> @@ -90,9 +90,6 @@ struct watchdog_ops {
>    *
>    * The driver-data field may not be accessed directly. It must be accessed
>    * via the watchdog_set_drvdata and watchdog_get_drvdata helpers.
> - *
> - * The lock field is for watchdog core internal use only and should not be
> - * touched.
>    */
>   struct watchdog_device {
>   	int id;
>