linux-kernel - Re: [PATCH v3 1/2] dmaengine: 8250_mtk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201812091331.sSRA3m4T%fengguang.wu@intel.com>
Date:   Sun, 9 Dec 2018 13:07:16 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Long Cheng <long.cheng@...iatek.com>
Cc:     kbuild-all@...org, Vinod Koul <vkoul@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        Sean Wang <sean.wang@...iatek.com>,
        Sean Wang <sean.wang@...nel.org>, dmaengine@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-serial@...r.kernel.org, srv_heupstream@...iatek.com,
        Yingjoe Chen <yingjoe.chen@...iatek.com>,
        YT Shen <yt.shen@...iatek.com>,
        Long Cheng <long.cheng@...iatek.com>
Subject: Re: [PATCH v3 1/2] dmaengine: 8250_mtk_dma: add Mediatek uart DMA
 support

Hi Long,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.20-rc5 next-20181207]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Long-Cheng/add-uart-DMA-function/20181208-201933
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=sh 

All errors (new ones prefixed by >>):

   In file included from include/linux/device.h:23:0,
                    from include/linux/dmaengine.h:20,
                    from drivers/dma/mediatek/8250_mtk_dma.c:10:
>> drivers/dma/mediatek/8250_mtk_dma.c:828:21: error: 'mtk_dma_runtime_suspend' undeclared here (not in a function); did you mean '__pm_runtime_suspend'?
     SET_RUNTIME_PM_OPS(mtk_dma_runtime_suspend,
                        ^
   include/linux/pm.h:354:21: note: in definition of macro 'SET_RUNTIME_PM_OPS'
     .runtime_suspend = suspend_fn, \
                        ^~~~~~~~~~
>> drivers/dma/mediatek/8250_mtk_dma.c:829:7: error: 'mtk_dma_runtime_resume' undeclared here (not in a function); did you mean 'mtk_dma_device_resume'?
          mtk_dma_runtime_resume, NULL)
          ^
   include/linux/pm.h:355:20: note: in definition of macro 'SET_RUNTIME_PM_OPS'
     .runtime_resume = resume_fn, \
                       ^~~~~~~~~
   drivers/dma/mediatek/8250_mtk_dma.c:164:13: warning: 'mtk_dma_clk_disable' defined but not used [-Wunused-function]
    static void mtk_dma_clk_disable(struct mtk_dmadev *mtkd)
                ^~~~~~~~~~~~~~~~~~~
   drivers/dma/mediatek/8250_mtk_dma.c:151:12: warning: 'mtk_dma_clk_enable' defined but not used [-Wunused-function]
    static int mtk_dma_clk_enable(struct mtk_dmadev *mtkd)
               ^~~~~~~~~~~~~~~~~~

vim +828 drivers/dma/mediatek/8250_mtk_dma.c

   825	
   826	static const struct dev_pm_ops mtk_dma_pm_ops = {
   827		SET_SYSTEM_SLEEP_PM_OPS(mtk_dma_suspend, mtk_dma_resume)
 > 828		SET_RUNTIME_PM_OPS(mtk_dma_runtime_suspend,
 > 829				   mtk_dma_runtime_resume, NULL)
   830	};
   831	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (50415 bytes)