lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 09 Dec 2018 21:50:33 +0000 From: Ben Hutchings <ben@...adent.org.uk> To: linux-kernel@...r.kernel.org, stable@...r.kernel.org CC: akpm@...ux-foundation.org, "Sabrina Dubroca" <sd@...asysnail.net>, "Steffen Klassert" <steffen.klassert@...unet.com>, "Thadeu Lima de Souza Cascardo" <cascardo@...onical.com> Subject: [PATCH 3.16 185/328] xfrm6: call kfree_skb when skb is toobig 3.16.62-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Thadeu Lima de Souza Cascardo <cascardo@...onical.com> commit 215ab0f021c9fea3c18b75e7d522400ee6a49990 upstream. After commit d6990976af7c5d8f55903bfb4289b6fb030bf754 ("vti6: fix PMTU caching and reporting on xmit"), some too big skbs might be potentially passed down to __xfrm6_output, causing it to fail to transmit but not free the skb, causing a leak of skb, and consequentially a leak of dst references. After running pmtu.sh, that shows as failure to unregister devices in a namespace: [ 311.397671] unregister_netdevice: waiting for veth_b to become free. Usage count = 1 The fix is to call kfree_skb in case of transmit failures. Fixes: dd767856a36e ("xfrm6: Don't call icmpv6_send on local error") Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@...onical.com> Reviewed-by: Sabrina Dubroca <sd@...asysnail.net> Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com> Signed-off-by: Ben Hutchings <ben@...adent.org.uk> --- net/ipv6/xfrm6_output.c | 2 ++ 1 file changed, 2 insertions(+) --- a/net/ipv6/xfrm6_output.c +++ b/net/ipv6/xfrm6_output.c @@ -158,9 +158,11 @@ static int __xfrm6_output(struct sk_buff if (toobig && xfrm6_local_dontfrag(skb)) { xfrm6_local_rxpmtu(skb, mtu); + kfree_skb(skb); return -EMSGSIZE; } else if (!skb->ignore_df && toobig && skb->sk) { xfrm_local_error(skb, mtu); + kfree_skb(skb); return -EMSGSIZE; }
Powered by blists - more mailing lists