linux-kernel - [tip:x86/build] x86/um: Remove -fno-unit-at-a-time workaround for pre-4.0 GCC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-829889ac4a7d26858860c297e64051bd27ce8fbe@git.kernel.org>
Date:   Sun, 9 Dec 2018 03:06:57 -0800
From:   tip-bot for Masahiro Yamada <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     bp@...e.de, richard@....at, mpe@...erman.id.au, x86@...nel.org,
        hpa@...or.com, tglx@...utronix.de, mingo@...hat.com,
        yamada.masahiro@...ionext.com, linux-kernel@...r.kernel.org,
        mingo@...nel.org
Subject: [tip:x86/build] x86/um: Remove -fno-unit-at-a-time workaround for
 pre-4.0 GCC

Commit-ID:  829889ac4a7d26858860c297e64051bd27ce8fbe
Gitweb:     https://git.kernel.org/tip/829889ac4a7d26858860c297e64051bd27ce8fbe
Author:     Masahiro Yamada <yamada.masahiro@...ionext.com>
AuthorDate: Mon, 12 Nov 2018 11:35:19 +0900
Committer:  Borislav Petkov <bp@...e.de>
CommitDate: Sun, 9 Dec 2018 11:51:11 +0100

x86/um: Remove -fno-unit-at-a-time workaround for pre-4.0 GCC

Commit

  cafa0010cd51 ("Raise the minimum required gcc version to 4.6")

bumped the minimum GCC version to 4.6 for all architectures.

'$(call cc-option,-fno-unit-at-a-time)' is now dead code since
'$(cc-version) -lt 0400' is always false. Remove it.

Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
Signed-off-by: Borislav Petkov <bp@...e.de>
Acked-by: Richard Weinberger <richard@....at>
Cc: "H. Peter Anvin" <hpa@...or.com>
Cc: Ingo Molnar <mingo@...hat.com>
Cc: Michael Ellerman <mpe@...erman.id.au>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: linuxppc-dev@...ts.ozlabs.org
Cc: x86-ml <x86@...nel.org>
Link: https://lkml.kernel.org/r/1541990120-9643-2-git-send-email-yamada.masahiro@socionext.com
---
 arch/x86/Makefile.um | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/arch/x86/Makefile.um b/arch/x86/Makefile.um
index 91085a08de6c..577976b7d1f8 100644
--- a/arch/x86/Makefile.um
+++ b/arch/x86/Makefile.um
@@ -26,12 +26,8 @@ cflags-y += $(call cc-option,-mpreferred-stack-boundary=2)
 # an unresolved reference.
 cflags-y += -ffreestanding
 
-# Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use
-# a lot more stack due to the lack of sharing of stacklots.  Also, gcc
-# 4.3.0 needs -funit-at-a-time for extern inline functions.
-KBUILD_CFLAGS += $(shell if [ $(cc-version) -lt 0400 ] ; then \
-			echo $(call cc-option,-fno-unit-at-a-time); \
-			else echo $(call cc-option,-funit-at-a-time); fi ;)
+# gcc 4.3.0 needs -funit-at-a-time for extern inline functions.
+KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time)
 
 KBUILD_CFLAGS += $(cflags-y)