linux-kernel - Re: [PATCH] x86: mm: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181211090219.52ef9144@canb.auug.org.au>
Date:   Tue, 11 Dec 2018 09:02:19 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Dave Hansen <dave.hansen@...ux.intel.com>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, Oscar Salvador <osalvador@...e.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>,
        Stefan Agner <stefan@...er.ch>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: mm: remove unused variable

Hi Arnd,

On Mon, 10 Dec 2018 21:53:02 +0100 Arnd Bergmann <arnd@...db.de> wrote:
>
> A recent change dropped the only user of the variable, which should
> now be removed as well to avoid this warning:
> 
> arch/x86/mm/init_32.c: In function 'arch_remove_memory':
> arch/x86/mm/init_32.c:867:15: error: unused variable 'zone' [-Werror=unused-variable]
> 
> Fixes: dd99d07f818b ("mm, memory_hotplug: move zone/pages handling to offline stage")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  arch/x86/mm/init_32.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c
> index 0b8c7b0033d2..c75c26497c4f 100644
> --- a/arch/x86/mm/init_32.c
> +++ b/arch/x86/mm/init_32.c
> @@ -864,7 +864,6 @@ int arch_remove_memory(int nid, u64 start, u64 size, struct vmem_altmap *altmap)
>  {
>  	unsigned long start_pfn = start >> PAGE_SHIFT;
>  	unsigned long nr_pages = size >> PAGE_SHIFT;
> -	struct zone *zone;
>  
>  	return remove_sections(nid, start_pfn, nr_pages, altmap);
>  }

I have added that to the akpm-current tree for today.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped