linux-kernel - Re: [PATCH 17/18] mfd: wm8350-core: drop unused MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Dec 2018 06:38:53 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        patches@...nsource.cirrus.com
Subject: Re: [PATCH 17/18] mfd: wm8350-core: drop unused MODULE_ tags from
 non-modular code

On Fri, 07 Dec 2018, Paul Gortmaker wrote:

> The Kconfig currently controlling compilation of this code is:
> 
> drivers/mfd/Kconfig:config MFD_WM8350
> drivers/mfd/Kconfig:    bool
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> We delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
> 
> We replace module.h with init.h and export.h ; the latter since the
> file does export some symbols.
> 
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: patches@...nsource.cirrus.com
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

When you submit this patch again (collecting more Acks or
what-have-you), please re-order your tags chronologically.

Your SoB here should represent the first time you submitted the patch,
therefore it would be impossible for Linus to review the patch on the
ML *before* you sent it.

> ---
>  drivers/mfd/wm8350-core.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c
> index 8a07c5634aee..e6434a4d7439 100644
> --- a/drivers/mfd/wm8350-core.c
> +++ b/drivers/mfd/wm8350-core.c
> @@ -13,7 +13,8 @@
>   */
>  
>  #include <linux/kernel.h>
> -#include <linux/module.h>
> +#include <linux/init.h>
> +#include <linux/export.h>
>  #include <linux/slab.h>
>  #include <linux/bug.h>
>  #include <linux/device.h>
> @@ -466,6 +467,3 @@ void wm8350_device_exit(struct wm8350 *wm8350)
>  	wm8350_irq_exit(wm8350);
>  }
>  EXPORT_SYMBOL_GPL(wm8350_device_exit);
> -
> -MODULE_DESCRIPTION("WM8350 AudioPlus PMIC core driver");
> -MODULE_LICENSE("GPL");

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog